[
https://issues.apache.org/jira/browse/HADOOP-16721?focusedWorklogId=561033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561033
]
ASF GitHub Bot logged work on HADOOP-16721:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/21 17:52
Start Date: 04/Mar/21 17:52
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2742:
URL: https://github.com/apache/hadoop/pull/2742#issuecomment-790807398
Testing with -Dparallel-tests -DtestsThreadCount=8 -Dmarkers=keep -Dscale
If the store is set to raise exceptions, a lot of tests which expect
rename(bad options) to return false now get exceptions. One of the contract
tests would downgrade if the raised exception was FileAlreadyExistsException
and the contract xml said that was ok. I'm reluctant to go with a bigger patch.
this PR is so that Hive and friends can get better reporting on errors,
rather than have them lost. It will be optional
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 561033)
Time Spent: 20m (was: 10m)
> Improve S3A rename resilience
> -----------------------------
>
> Key: HADOOP-16721
> URL: https://issues.apache.org/jira/browse/HADOOP-16721
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Improve rename resilience in two ways.
> h3. parent dir probes
> allow an option skip the LIST for the parent and just do HEAD object to makes
> sure it is not a file.
> h3. failure reporting
> the classic \{[rename(source, dest)}} operation returns \{{false}} on certain
> failures, which, while somewhat consistent with the posix APIs, turns out to
> be useless for identifying the cause of problems. Applications tend to have
> code which goes
> {code}
> if (!fs.rename(src, dest)) throw new IOException("rename failed");
> {code}
> While ultimately the rename/3 call needs to be made public (HADOOP-11452) it
> would then need a adoption across applications. We can do this in the hadoop
> modules, but for Hive, Spark etc it will take along time.
> Proposed: a switch to tell S3A to stop downgrading certain failures (source
> is dir, dest is file, src==dest, etc) into "false". This can be turned on
> when trying to diagnose why things like Hive are failing.
> Production code: trivial
> * change in rename(),
> * new option
> * docs.
> Test code:
> * need to clear this option for rename contract tests
> * need to create a new FS with this set to verify the various failure modes
> trigger it.
>
> If this works we should do the same for ABFS, GCS. Hey, maybe even HDFS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
