ayushtkn commented on a change in pull request #2746:
URL: https://github.com/apache/hadoop/pull/2746#discussion_r589419978
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
##########
@@ -631,10 +698,10 @@ public void testTruncateFailure() throws IOException {
{
try {
fs.truncate(p, 0);
- fail("Truncate must fail since a trancate is already in pregress.");
+ fail("Truncate must fail since a truncate is already in progress.");
} catch (IOException expected) {
GenericTestUtils.assertExceptionContains(
- "Failed to TRUNCATE_FILE", expected);
+ "/dir/testTruncateFailure is being truncated", expected);
}
Review comment:
What is the difference between this case and ours? Why doesn't this
exception triggers for our case? and can we accommodate our fix to the check
throwing this exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
