goiri commented on a change in pull request #2741:
URL: https://github.com/apache/hadoop/pull/2741#discussion_r589533032
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEnabledECPolicies.java
##########
@@ -143,7 +143,7 @@ public void testChangeDefaultPolicy() throws Exception {
testPolicy);
manager.init(conf);
// Load policies similar to when fsimage is loaded at namenode startup
- manager.loadPolicies(constructAllDisabledInitialPolicies(), conf);
+ manager.loadPolicies(constructAllDisabledInitialPolicies(), conf, null);
Review comment:
Can we add a test with the counter being passed?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
##########
@@ -482,11 +483,15 @@ private void loadPolicy(ErasureCodingPolicyInfo info) {
*
*/
public synchronized void loadPolicies(
- List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf)
+ List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf,
Review comment:
Can you leave the old header passing a null so we don't need to modify
the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
