iwasakims commented on pull request #2742: URL: https://github.com/apache/hadoop/pull/2742#issuecomment-793993687
LGTM overall. Tests against Tokyo region worked. I just left comments for nits. ``` $ mvn verify -Dtest=x -Dit.test=ITestS3AContractRename,ITestlRenameDeleteRace -Ds3guard ... [INFO] Running org.apache.hadoop.fs.s3a.impl.ITestlRenameDeleteRace [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.044 s - in org.apache.hadoop.fs.s3a.impl.ITestlRenameDeleteRace [INFO] Running org.apache.hadoop.fs.s3a.ITestS3GuardListConsistency [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.603 s - in org.apache.hadoop.fs.s3a.ITestS3GuardListConsistency [INFO] Running org.apache.hadoop.fs.contract.s3a.ITestS3AContractRename [WARNING] Tests run: 22, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 12.523 s - in org.apache.hadoop.fs.contract.s3a.ITestS3AContractRename ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
