[ 
https://issues.apache.org/jira/browse/HADOOP-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134474#comment-13134474
 ] 

[email protected] commented on HADOOP-7764:
-------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2549/#review2804
-----------------------------------------------------------



hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
<https://reviews.apache.org/r/2549/#comment6276>

    This new constructor seems like the new fully featured one.  Why not make 
all other constructors call into this one? and move over the code as needed to 
do it?


- Robert


On 2011-10-24 20:30:15, Jonathan Eagles wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2549/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-24 20:30:15)
bq.  
bq.  
bq.  Review request for Robert Evans, Ravi Prakash and Mark Holderbaugh.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  HttpServer allows setting global path spec filters in one constructor and 
ACL list in another constructor. Having both set in HttpServer is not user 
settable either by public API or constructor.
bq.  
bq.  This feature is needed for MAPREDUCE-3175. No tests were added since no 
new functionality was added. Only a single API change.
bq.  
bq.  
bq.  This addresses bug HADOOP-7764.
bq.      http://issues.apache.org/jira/browse/HADOOP-7764
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
 6ad3703 
bq.  
bq.  Diff: https://reviews.apache.org/r/2549/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jonathan
bq.  
bq.


                
> Allow both ACL list and global path spec filters to HttpServer
> --------------------------------------------------------------
>
>                 Key: HADOOP-7764
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7764
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-7764.patch
>
>
> HttpServer allows setting global path spec filters in one constructor and ACL 
> list in another constructor. Having both set in HttpServer is not user 
> settable either by public API or constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to