steveloughran commented on pull request #2732: URL: https://github.com/apache/hadoop/pull/2732#issuecomment-799684654
Problem is this: https://github.com/steveloughran/hadoop/blob/s3/HADOOP-17511-auditing/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java I'm wrapping each of the ops in an enter/exit of auditing, the changes are pretty traumatic. Unless I can rework how the invocation happens, we'll need to keep them separate. Here's what I'd like to propose * your patches copies, rather than moves callable supplier. Maybe give it a new name to distinguish it from the one in s3 * the old one stays in aws s3, same name etc. Your patch can go in to trunk and I can co-exist my dev with it. If I can see a way to move I'll adopt, but it will allow us to diverge, with the hadoop common CallableSupplier more broadly used ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
