snehavarma commented on a change in pull request #1925:
URL: https://github.com/apache/hadoop/pull/1925#discussion_r595726080
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java
##########
@@ -208,6 +208,10 @@
DefaultValue = DEFAULT_FS_AZURE_APPEND_BLOB_DIRECTORIES)
private String azureAppendBlobDirs;
+ @StringConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_SINGLE_WRITER_KEY,
Review comment:
please use a different name. It might cause confusion
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java
##########
@@ -87,6 +87,9 @@
/** Provides a config to provide comma separated path prefixes on which
Appendblob based files are created
* Default is empty. **/
public static final String FS_AZURE_APPEND_BLOB_KEY =
"fs.azure.appendblob.directories";
+ /** Provides a config to provide comma separated path prefixes which support
single writers.
+ * Default is empty. **/
+ public static final String FS_AZURE_SINGLE_WRITER_KEY =
"fs.azure.singlewriter.directories";
Review comment:
might want to use a different name
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -145,8 +148,11 @@
private static final String XMS_PROPERTIES_ENCODING = "ISO-8859-1";
private static final int GET_SET_AGGREGATE_COUNT = 2;
+ private final Map<SelfRenewingLease,Object> leaseRefs;
Review comment:
The naming should be changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
