vivekratnavel commented on a change in pull request #2784:
URL: https://github.com/apache/hadoop/pull/2784#discussion_r598154449
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
##########
@@ -7665,7 +7670,7 @@ void addCachePool(CachePoolInfo req, boolean
logRetryCache)
checkOperation(OperationCategory.WRITE);
String poolInfoStr = null;
try {
- checkSuperuserPrivilege();
+ checkSuperuserPrivilege(operationName);
Review comment:
That's a good suggestion @xiaoyuyao. We cannot add the cache pool name
for "addCachePool()" method since the superuser check needs to happen before
adding the cache pool and we get the name only after it's added. But, I will
set the cache pool name in context for modify and remove methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
