[
https://issues.apache.org/jira/browse/HADOOP-13551?focusedWorklogId=570412&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570412
]
ASF GitHub Bot logged work on HADOOP-13551:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 12:54
Start Date: 23/Mar/21 12:54
Worklog Time Spent: 10m
Work Description: mukund-thakur commented on a change in pull request
#2778:
URL: https://github.com/apache/hadoop/pull/2778#discussion_r599415813
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java
##########
@@ -226,31 +170,6 @@ protected static AmazonS3 configureAmazonS3Client(AmazonS3
s3,
throw new IllegalArgumentException(msg, e);
}
}
Review comment:
nit: a bit of commentry about path style access was good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 570412)
Time Spent: 4h 20m (was: 4h 10m)
> Collect AwsSdkMetrics in S3A FileSystem IOStatistics
> ----------------------------------------------------
>
> Key: HADOOP-13551
> URL: https://issues.apache.org/jira/browse/HADOOP-13551
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-beta1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> The S3A Connector has the ability to pass statistics collected by the AWS SDK
> into the IOStatistics store of the (stream, FS)
> But
> * wiring up doesn't (yet) work
> * its best if there was thread-context level collection, though FS-level
> statistics would be a good start.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
