[
https://issues.apache.org/jira/browse/HADOOP-17133?focusedWorklogId=570928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570928
]
ASF GitHub Bot logged work on HADOOP-17133:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/21 04:37
Start Date: 24/Mar/21 04:37
Worklog Time Spent: 10m
Work Description: aajisaka commented on a change in pull request #2145:
URL: https://github.com/apache/hadoop/pull/2145#discussion_r600160149
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
##########
@@ -1227,6 +1242,16 @@ public void start() throws IOException {
.register("prometheus", "Hadoop metrics prometheus exporter",
prometheusMetricsSink);
}
+ if (statsHandler != null) {
+ // Create metrics source for each HttpServer2 instance.
+ // Use port number to make the metrics source name unique.
+ int port = -1;
+ for (ServerConnector connector : listeners) {
+ port = connector.getLocalPort();
+ break;
+ }
+ metrics = HttpServer2Metrics.create(statsHandler, port);
Review comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 570928)
Time Spent: 20m (was: 10m)
> Implement HttpServer2 metrics
> -----------------------------
>
> Key: HADOOP-17133
> URL: https://issues.apache.org/jira/browse/HADOOP-17133
> Project: Hadoop Common
> Issue Type: Improvement
> Components: httpfs, kms
> Reporter: Akira Ajisaka
> Assignee: Akira Ajisaka
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I'd like to collect metrics (number of connections, average response time,
> etc...) from HttpFS and KMS but there are no metrics for HttpServer2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
