aajisaka commented on a change in pull request #2145:
URL: https://github.com/apache/hadoop/pull/2145#discussion_r600192098
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
##########
@@ -669,6 +674,16 @@ private void initializeWebServer(String name, String
hostName,
addDefaultApps(contexts, appDir, conf);
webServer.setHandler(handlers);
+ // Jetty StatisticsHandler should be the first handler.
+ // The handler returns 503 if there is no next handler and the response is
+ // not committed. In Apache Hadoop, there are some servlets that do not
+ // commit (i.e. close) the response. Therefore the handler fails.
Review comment:
- I found why the handler should be inserted and updated the
explanation: https://www.eclipse.org/lists/jetty-users/msg06273.html
- Created a test case for the scenario:
https://github.com/apache/hadoop/pull/2145/commits/34bb0a6855cec3faca4a5b7eec323b5ca273743d
Thank you @Jing9 for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
