[
https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136373#comment-13136373
]
Sanjay Radia commented on HADOOP-7773:
--------------------------------------
Please replace your
{code}
public Server(Object instance, Configuration conf, String bindAddress,
int port, int numHandlers, int numReaders, int queueSizePerHandler,
boolean verbose, SecretManager<? extends TokenIdentifier> secretManager)
{code}
by
{code}
public <PROTO, IMPL extends PROTO> Server(Class<PROTO> protocolClass, IMPL
protocolImpl,
Configuration conf, String bindAddress, int port,
int numHandlers, int numReaders, int queueSizePerHandler,
boolean verbose, SecretManager<? extends TokenIdentifier>
secretManager)
{code}
Also change your RPC.server getServer(...) accordingly.
Style suggestion.
You have 2 methods after your "static class Server"; please move them to before
so that all the methods of ProtobufRpcEngine are together.
Please add tests.
+1 otherwise.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
