xiaoyuyao commented on a change in pull request #2784:
URL: https://github.com/apache/hadoop/pull/2784#discussion_r604564623
##########
File path: hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
##########
@@ -310,4 +310,10 @@
<Method name="reconcile" />
<Bug pattern="SWL_SLEEP_WITH_LOCK_HELD" />
</Match>
+ <!-- Manually verified that r can never be null and cannot result in NPE
-->
Review comment:
can we revert the formatting change in findbugsExcludeFile.xml as the
assert should fix the spotbugs issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
