tasanuma commented on a change in pull request #2770:
URL: https://github.com/apache/hadoop/pull/2770#discussion_r605551460
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
##########
@@ -87,6 +87,8 @@
MutableGaugeInt blockOpsQueued;
@Metric("Number of blockReports and blockReceivedAndDeleted batch processed")
MutableCounterLong blockOpsBatched;
+ @Metric("Number of edit pending")
+ MutableGaugeInt editPendingCount;
Review comment:
I'm not a native English speaker, but I feel the following is more
natural. What do you think?
```suggestion
@Metric("Number of pending edits")
MutableGaugeInt pendingEditsCount;
```
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
##########
@@ -87,6 +87,8 @@
MutableGaugeInt blockOpsQueued;
@Metric("Number of blockReports and blockReceivedAndDeleted batch processed")
MutableCounterLong blockOpsBatched;
+ @Metric("Number of edit pending")
+ MutableGaugeInt editPendingCount;
Review comment:
Could you add the description to
`./hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
