liuml07 commented on pull request #2830: URL: https://github.com/apache/hadoop/pull/2830#issuecomment-812233579
@virajjasani Just saw you have multiple PRs recently. In Hadoop, the PR title and git commit subject starts with format: ``` HADOOP-12345. Fix foo. Contributed by Viraj ``` So the `.` instead of `:`. I personally am fine with either char, but looks like the convention is to have `.` instead of space and colon ` :` to join the JIRA number and subject. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
