Hexiaoqiao commented on a change in pull request #2872:
URL: https://github.com/apache/hadoop/pull/2872#discussion_r607862424
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
##########
@@ -252,7 +252,7 @@ public void setTransactionId(long txid) {
}
public boolean hasRpcIds() {
- return rpcClientId != RpcConstants.DUMMY_CLIENT_ID
+ return !Arrays.equals(rpcClientId, RpcConstants.DUMMY_CLIENT_ID)
Review comment:
Thanks @WeisonWei , It is interesting catches. There will be some other
place has the same un-corrected compares, Would you like to correct it at the
same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
