[
https://issues.apache.org/jira/browse/HADOOP-17611?focusedWorklogId=580779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-580779
]
ASF GitHub Bot logged work on HADOOP-17611:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/21 05:26
Start Date: 12/Apr/21 05:26
Worklog Time Spent: 10m
Work Description: jojochuang commented on a change in pull request #2892:
URL: https://github.com/apache/hadoop/pull/2892#discussion_r611335147
##########
File path:
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java
##########
@@ -635,7 +635,10 @@ private void concatFileChunks(Configuration conf, Path
sourceFile,
++i;
}
}
+ long firstChunkLastModifiedTs = dstfs.getFileStatus(firstChunkFile)
+ .getModificationTime();
dstfs.concat(firstChunkFile, restChunkFiles);
+ dstfs.setTimes(firstChunkFile, firstChunkLastModifiedTs, -1);
Review comment:
I think you should update mtime after rename(). The HDFS rename updates
mtime too. Not sure about other file system implementations but it's safe to
assume that being the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 580779)
Time Spent: 0.5h (was: 20m)
> Distcp parallel file copy breaks the modification time
> ------------------------------------------------------
>
> Key: HADOOP-17611
> URL: https://issues.apache.org/jira/browse/HADOOP-17611
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Adam Maroti
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The commit HADOOP-11794. Enable distcp to copy blocks in parallel.
> (bf3fb585aaf2b179836e139c041fc87920a3c886) broke the modification time of
> large files.
>
> In CopyCommitter.java inside concatFileChunks Filesystem.concat is called
> which changes the modification time therefore the modification times of files
> copeid by distcp will not match the source files. However this only occurs
> for large enough files, which are copied by splitting them up by distcp.
> In concatFileChunks before calling concat extract the modification time and
> apply that to the concatenated result-file after the concat. (probably best
> -after- before the rename()).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
