amahussein commented on a change in pull request #2878:
URL: https://github.com/apache/hadoop/pull/2878#discussion_r613382377
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##########
@@ -378,13 +381,18 @@ public void logSyncWait() {
@Override
public void logSyncNotify(RuntimeException syncEx) {
- try {
- if (syncEx == null) {
- call.sendResponse();
- } else {
- call.abortResponse(syncEx);
+ for (int retries = 0; retries <= RESPONSE_SEND_RETRIES; retries++) {
Review comment:
@functioner Thanks for the explanation.
Adding an explicit IOException alters the purpose of the implementation. In
order to observe the symptom of client, the faultInjection needs to be closer
to what the code was implemented for. For example, instead of throwing an
exception, a faultijection should be added to the rpc-call so that
`call.sendResponse()/call.abortResponse(syncEx)` would throw the appropriate
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
