virajjasani commented on a change in pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907#discussion_r613775043
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableCounterLong.java
##########
@@ -32,11 +32,11 @@
@InterfaceStability.Evolving
public class MutableCounterLong extends MutableCounter {
- private AtomicLong value = new AtomicLong();
+ private LongAdder value = new LongAdder();
Review comment:
nit: this can be `final`
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
##########
@@ -771,7 +771,7 @@ private void printStatistics(boolean force) {
.append(" Total time for transactions(ms): ")
.append(totalTimeTransactions)
.append(" Number of transactions batched in Syncs: ")
- .append(numTransactionsBatchedInSync.get())
+ .append(numTransactionsBatchedInSync.longValue())
Review comment:
How frequently this gets printed compared to `longSync()`?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOpsCountStatistics.java
##########
@@ -141,21 +141,21 @@ public static OpType fromSymbol(String symbol) {
public static final String NAME = "DFSOpsCountStatistics";
- private final Map<OpType, AtomicLong> opsCount = new EnumMap<>(OpType.class);
+ private final Map<OpType, LongAdder> opsCount = new EnumMap<>(OpType.class);
public DFSOpsCountStatistics() {
super(NAME);
for (OpType opType : OpType.values()) {
- opsCount.put(opType, new AtomicLong(0));
+ opsCount.put(opType, new LongAdder());
}
}
public void incrementOpCounter(OpType op) {
- opsCount.get(op).addAndGet(1);
+ opsCount.get(op).increment();
}
private class LongIterator implements Iterator<LongStatistic> {
- private Iterator<Entry<OpType, AtomicLong>> iterator =
+ private Iterator<Entry<OpType, LongAdder>> iterator =
Review comment:
good to declare this `final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
