aajisaka commented on a change in pull request #2910:
URL: https://github.com/apache/hadoop/pull/2910#discussion_r613976067
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java
##########
@@ -371,13 +372,13 @@ private static void setStateStoreVersions(
}
@Override
- public long getTotalCapacity() {
- return getNameserviceAggregatedLong(MembershipStats::getTotalSpace);
+ public BigInteger getTotalCapacity() {
Review comment:
Adding new metrics is okay to me. Thanks.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java
##########
@@ -371,13 +372,13 @@ private static void setStateStoreVersions(
}
@Override
- public long getTotalCapacity() {
- return getNameserviceAggregatedLong(MembershipStats::getTotalSpace);
+ public BigInteger getTotalCapacity() {
Review comment:
Adding new metrics is also okay to me. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
