virajjasani commented on pull request #2945: URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825016629
> > side issue: is there a way we could block curator.shaded imports? They're clearly accidental IDE ones...having them rejected in yetus &c would be great > > We can warn the imports by updating the illegal import section in checkstyle.yml. > https://github.com/apache/hadoop/blob/eac7aefaafb1a4a02c272b60edfdf7b22d1771e2/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml#L122-L126 @aajisaka Although this is good option, but code can still be checked-in with this import. In addition to this change, we can also use `restrict-imports-enforcer-rule` dependency to restrict import such that if used, we will see mvn build failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
