[
https://issues.apache.org/jira/browse/HADOOP-17653?focusedWorklogId=587375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587375
]
ASF GitHub Bot logged work on HADOOP-17653:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/21 17:00
Start Date: 22/Apr/21 17:00
Worklog Time Spent: 10m
Work Description: virajjasani edited a comment on pull request #2945:
URL: https://github.com/apache/hadoop/pull/2945#issuecomment-825016629
> > side issue: is there a way we could block curator.shaded imports?
They're clearly accidental IDE ones...having them rejected in yetus &c would be
great
>
> We can warn the imports by updating the illegal import section in
checkstyle.yml.
>
https://github.com/apache/hadoop/blob/eac7aefaafb1a4a02c272b60edfdf7b22d1771e2/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml#L122-L126
@aajisaka Although this is good option, but code can still be checked-in
with this import. In addition to this change, we can also use
`restrict-imports-enforcer-rule` dependency to restrict import such that if
used, we will see mvn build failure.
If you are fine, I can create PR with this enforcer in parallel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587375)
Time Spent: 1h 20m (was: 1h 10m)
> Do not use guava's Files.createTempDir()
> ----------------------------------------
>
> Key: HADOOP-17653
> URL: https://issues.apache.org/jira/browse/HADOOP-17653
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.0
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
