[
https://issues.apache.org/jira/browse/HADOOP-17485?focusedWorklogId=589699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589699
]
ASF GitHub Bot logged work on HADOOP-17485:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/21 12:21
Start Date: 27/Apr/21 12:21
Worklog Time Spent: 10m
Work Description: amahussein commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-827562798
> `Inconsistent synchronization of
org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time
Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized
access at LdapGroupsMapping.java:[line 596]`
> Was this caused by this PR or was it already there before/
I think this PR added `public Set<String> getGroupsSet(String user)` in line
[LdapGroupsMapping#627](https://github.com/apache/hadoop/pull/2631/files#diff-34cbaed59eb28984bdb38185b850527c6bc2088d2295fee6657333084aeab668R627)
that is not synchronized which in turn calls `doGetGroups()`. Perhaps this is
why `findbugs` finds it a concurrency issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 589699)
Time Spent: 50m (was: 40m)
> port UGI#getGroupsSet optimizations into 2.10
> ---------------------------------------------
>
> Key: HADOOP-17485
> URL: https://issues.apache.org/jira/browse/HADOOP-17485
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.10.1
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> HADOOP-17079 introduced an optimization adding a UGI#getGroupsSet and use
> Set#contains() instead of List#contains() to speed up large group look up
> while minimize List->Set conversions in Groups#getGroups() call.
> This ticket is to port the changes into branch-2.10.
>
> CC: [~Jim_Brennan], [~xyao]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
