amahussein commented on pull request #2985:
URL: https://github.com/apache/hadoop/pull/2985#issuecomment-836905659
> Sure let me restrict this PR to only hadoop-common and hadoop-tools only
and once merged, will create dependent PRs
@virajjasani thanks for the changes.
I agree with @busbey that the PR should be split into modules.
However, since you already got an idea of what wrappers need to be
implemented to replace the {{Guava.sets}}, it may be better to create a PR only
for the wrappers (including TreeSets), then once that code is merged, you can
replace the guava.sets in every module.
I am a little bit sure I understand why `Sets.newHashSet(E element...)`
should be used. This is coming from guava.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
