goiri commented on a change in pull request #2981:
URL: https://github.com/apache/hadoop/pull/2981#discussion_r631274370
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java
##########
@@ -1036,6 +1057,83 @@ private boolean updateQuota(String mount, long nsQuota,
long ssQuota)
return updateResponse.getStatus();
}
+ /**
+ * Initialize the ViewFS mount point to the Router,
+ * either to specify a cluster or to initialize it all.
+ * @param clusterName The specified cluster to initialize,
+ * AllCluster was then all clusters.
+ * @return If the quota was updated.
+ * @throws IOException Error adding the mount point.
+ */
+ public boolean initViewFsToMountTable(String clusterName)
+ throws IOException {
+ // fs.viewfs.mounttable.ClusterX.link./data
+ final String mountTablePrefix;
+ if (clusterName.equals(ALL_CLUSTERS)) {
+ mountTablePrefix =
+ Constants.CONFIG_VIEWFS_PREFIX + ".*" +
+ Constants.CONFIG_VIEWFS_LINK + ".";
+ } else {
+ mountTablePrefix =
+ Constants.CONFIG_VIEWFS_PREFIX + "." + clusterName + "." +
+ Constants.CONFIG_VIEWFS_LINK + ".";
+ }
+ final String rootPath = "/";
+ Map<String, String> viewFsMap = getConf().getValByRegex(
+ mountTablePrefix + rootPath);
+ if (viewFsMap.isEmpty()) {
+ System.out.println("There is no ViewFs mapping to initialize.");
+ return true;
+ }
+ for (Entry<String, String> entry : viewFsMap.entrySet()) {
+ Path path = new Path(entry.getValue());
+ URI destUri = path.toUri();
+ String mountKey = entry.getKey();
+ DestinationOrder order = DestinationOrder.HASH;
+ String mount = mountKey.replaceAll(mountTablePrefix, "");
+ if (!destUri.getScheme().equals("hdfs")) {
+ System.out.println("Only supports HDFS, " +
+ "added Mount Point failed , " + mountKey);
+ }
+ if (!mount.startsWith(rootPath) ||
+ !destUri.getPath().startsWith(rootPath)) {
+ System.out.println("Added Mount Point failed " + mountKey);
+ continue;
+ }
+ String[] nss = new String[]{destUri.getAuthority()};
+ boolean added = addMount(
+ mount, nss, destUri.getPath(), false,
+ false, order, getACLEntityFormHdfsPath(path, getConf()));
+ if (added) {
+ System.out.println("Added mount point " + mount);
+ }
+ }
+ return true;
+ }
+
+ /**
+ * Returns ACLEntity according to a HDFS pat.
+ * @param path A path of HDFS.
+ */
+ static public ACLEntity getACLEntityFormHdfsPath(
Review comment:
I think the order is usually public static.
It could also be private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
