haiyang1987 edited a comment on pull request #2747:
URL: https://github.com/apache/hadoop/pull/2747#issuecomment-842136488


   @ferhui Thanks for reviewing.
   This does not seem to cause any problems in production,
   However  in this case the debug log output execution information is a 
problem.
   
   
   ```java
   BlockManager#computeReconstructionWorkForBlocks
   int computeReconstructionWorkForBlocks(
         List<List<BlockInfo>> blocksToReconstruct) {
       ...
       if (blockLog.isDebugEnabled()) {
         // log which blocks have been scheduled for reconstruction
         for (BlockReconstructionWork rw : reconWork) {
           DatanodeStorageInfo[] targets = rw.getTargets();
           if (targets != null && targets.length != 0) {
             StringBuilder targetList = new StringBuilder("datanode(s)");
             for (DatanodeStorageInfo target : targets) {
               targetList.append(' ').append(target.getDatanodeDescriptor());
             }
             blockLog.debug("BLOCK* ask {} to replicate {} to {}", 
rw.getSrcNodes(),
                 rw.getBlock(), targetList);
           }
       ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to