[
https://issues.apache.org/jira/browse/HADOOP-17700?focusedWorklogId=597932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597932
]
ASF GitHub Bot logged work on HADOOP-17700:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 18:13
Start Date: 17/May/21 18:13
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #3015:
URL: https://github.com/apache/hadoop/pull/3015#issuecomment-842281065
+1
One aspect of the Exit code design was that returning != 0 doesn't mean
print a stack trace at info. So the exit() calls must only log the message at
info, full stack at debug for the curious.
halt() is a different story. Looking at the hadoop code there's nowhere
where halt is called that it isn't some kind of emergency, often where exit()
raised an exception. Which means the stack is important.
Given it's logging the stack at info, what about cutting the DEBUG logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597932)
Time Spent: 1.5h (was: 1h 20m)
> ExitUtil#halt info log with incorrect placeholders
> --------------------------------------------------
>
> Key: HADOOP-17700
> URL: https://issues.apache.org/jira/browse/HADOOP-17700
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> ExitUtil#halt with non-zero exit status code provides info log with incorrect
> no of placeholders. We should log HaltException with the log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
