[ 
https://issues.apache.org/jira/browse/HADOOP-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349581#comment-17349581
 ] 

Duo Zhang commented on HADOOP-16377:
------------------------------------

I think this issue should be done prior to HADOOP-16206.

It is not easy to purge all the log4j dependencies, as slf4j does not provide 
all the necessary abilities. For example, you must touch the actual logging 
framework to change the log level, you can not do it through slf4j.

What I have done in HBase is to introduce a hbase-logging module, keep all the 
direct reference to log4j only in this module, but set log4j dependencies as 
provided in the pom of this module. And then actually pull log4j in when 
running UTs, and also in the finally assembly stage.

> Moving logging APIs over to slf4j
> ---------------------------------
>
>                 Key: HADOOP-16377
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16377
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: HADOOP-16357-002.patch, HADOOP-16377-001.patch, 
> HADOOP-16377-003.patch, HADOOP-16377-004.patch, HADOOP-16377-005.patch, 
> HADOOP-16377-006.patch, HADOOP-16377-007.patch, HADOOP-16377-008.patch, 
> HADOOP-16377-009.patch
>
>
> As of today, there are still 50 references to log4j1
> {code}
> $ grep -r "import org.apache.commons.logging.Log;" . |wc - l
>       50
> {code}
> To achieve the goal of HADOOP-12956/HADOOP-16206, we should invest time to 
> move them to slf4j



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to