[
https://issues.apache.org/jira/browse/HADOOP-17727?focusedWorklogId=601343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601343
]
ASF GitHub Bot logged work on HADOOP-17727:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 19:09
Start Date: 24/May/21 19:09
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3043:
URL: https://github.com/apache/hadoop/pull/3043#discussion_r638210967
##########
File path: dev-support/docker/pkg-resolver/install-common-pkgs.sh
##########
@@ -0,0 +1,98 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#######
+# Install SpotBugs 4.2.2
+#######
+mkdir -p /opt/spotbugs &&
+ curl -L -s -S
https://github.com/spotbugs/spotbugs/releases/download/4.2.2/spotbugs-4.2.2.tgz
\
+ -o /opt/spotbugs.tgz &&
+ tar xzf /opt/spotbugs.tgz --strip-components 1 -C /opt/spotbugs &&
+ chmod +x /opt/spotbugs/bin/*
+
+#######
+# Install Boost 1.72 (1.71 ships with Focal)
+#######
+# hadolint ignore=DL3003
+mkdir -p /opt/boost-library &&
+ curl -L
https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download
>boost_1_72_0.tar.bz2 &&
+ mv boost_1_72_0.tar.bz2 /opt/boost-library &&
+ cd /opt/boost-library &&
+ tar --bzip2 -xf boost_1_72_0.tar.bz2 &&
+ cd /opt/boost-library/boost_1_72_0 &&
+ ./bootstrap.sh --prefix=/usr/ &&
+ ./b2 --without-python install &&
+ cd /root &&
+ rm -rf /opt/boost-library
+
+######
+# Install Google Protobuf 3.7.1 (3.6.1 ships with Focal)
+######
+# hadolint ignore=DL3003
+mkdir -p /opt/protobuf-src &&
+ curl -L -s -S \
+
https://github.com/protocolbuffers/protobuf/releases/download/v3.7.1/protobuf-java-3.7.1.tar.gz
\
+ -o /opt/protobuf.tar.gz &&
+ tar xzf /opt/protobuf.tar.gz --strip-components 1 -C /opt/protobuf-src &&
+ cd /opt/protobuf-src &&
+ ./configure --prefix=/opt/protobuf &&
+ make "-j$(nproc)" &&
+ make install &&
+ cd /root &&
+ rm -rf /opt/protobuf-src
+
+######
+# Install pylint and python-dateutil
+######
+pip3 install pylint==2.6.0 python-dateutil==2.8.1
Review comment:
Are we sure this is already installed once we call this?
##########
File path: dev-support/docker/pkg-resolver/install-common-pkgs.sh
##########
@@ -0,0 +1,98 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#######
+# Install SpotBugs 4.2.2
+#######
+mkdir -p /opt/spotbugs &&
+ curl -L -s -S
https://github.com/spotbugs/spotbugs/releases/download/4.2.2/spotbugs-4.2.2.tgz
\
+ -o /opt/spotbugs.tgz &&
+ tar xzf /opt/spotbugs.tgz --strip-components 1 -C /opt/spotbugs &&
+ chmod +x /opt/spotbugs/bin/*
+
+#######
+# Install Boost 1.72 (1.71 ships with Focal)
+#######
+# hadolint ignore=DL3003
+mkdir -p /opt/boost-library &&
Review comment:
Would it make sense to have a file for each of them?
I can see possible future differences depending on the version.
##########
File path: dev-support/docker/Dockerfile_aarch64
##########
@@ -33,61 +33,19 @@ ENV DEBIAN_FRONTEND noninteractive
ENV DEBCONF_TERSE true
######
-# Install common dependencies from packages. Versions here are either
-# sufficient or irrelevant.
+# Platform package dependency resolver
######
-# hadolint ignore=DL3008
+COPY pkg-resolver pkg-resolver
+RUN chmod a+x pkg-resolver/install-common-pkgs.sh pkg-resolver/resolve.py \
Review comment:
We don't seem to be calling install-common-pkgs.sh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601343)
Time Spent: 2h 20m (was: 2h 10m)
> Modularize docker images
> ------------------------
>
> Key: HADOOP-17727
> URL: https://issues.apache.org/jira/browse/HADOOP-17727
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We're now creating the *Dockerfile*s for different platforms. We need a way
> to manage the packages in a clean way as maintaining the packages for all the
> different environments becomes cumbersome.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
