[
https://issues.apache.org/jira/browse/HADOOP-17126?focusedWorklogId=601828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601828
]
ASF GitHub Bot logged work on HADOOP-17126:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/21 16:21
Start Date: 25/May/21 16:21
Worklog Time Spent: 10m
Work Description: amahussein opened a new pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050
## NOTICE
In order to replace Guava Preconditions, we need to implement our own
versions of the API.
This PR is to create `checkNotNull` in a new package dubbed `unguava`.
This is splitting the PR that was opened previously #2134
**The plan is as follows**
- create a new `package org.apache.hadoop.util.unguava`;
- create `class Validate`
- implement `org.apache.hadoop.util.unguava.Validate` with the following
interface
- `checkNotNull(final T obj)`
- `checkNotNull(final T reference, final Object errorMessage)`
- `checkNotNull(final T obj, final String message, final Object... values)`
- `checkNotNull(final T obj,final Supplier<String> msgSupplier)`
- `guava.preconditions` used `String.lenientformat` which suppressed
exceptions caused by string formatting of the exception message . So, in order
to avoid changing the behavior, the implementation catches exceptions triggered
by building the message (IllegalFormat, InsufficientArg, NullPointer..etc)
- After merging the new class, we can replace
`guava.Preconditions.checkNotNull` by `unguava.Validate.checkNotNull`
- We need the change to go into trunk, 3.1, 3.2, and 3.3
Similar Jiras will be created to implement `checkState`, `checkArgument`,
`checkIndex`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601828)
Time Spent: 1h 10m (was: 1h)
> implement non-guava Precondition checkNotNull
> ---------------------------------------------
>
> Key: HADOOP-17126
> URL: https://issues.apache.org/jira/browse/HADOOP-17126
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-17126.001.patch, HADOOP-17126.002.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part In order to replace Guava Preconditions, we need to implement our own
> versions of the API.
> This Jira is to create {{checkNotNull}} in a new package dubbed {{unguava}}.
> +The plan is as follows+
> * create a new {{package org.apache.hadoop.util.unguava;}}
> * {{create class Validate}}
> * implement {{package org.apache.hadoop.util.unguava.Validate;}} with the
> following interface
> ** {{checkNotNull(final T obj)}}
> ** {{checkNotNull(final T reference, final Object errorMessage)}}
> ** {{checkNotNull(final T obj, final String message, final Object...
> values)}}
> ** {{checkNotNull(final T obj,final Supplier<String> msgSupplier)}}
> * {{guava.preconditions used String.lenientformat which suppressed
> exceptions caused by string formatting of the exception message . So, in
> order to avoid changing the behavior, the implementation catches Exceptions
> triggered by building the message (IllegalFormat, InsufficientArg,
> NullPointer..etc)}}
> * {{After merging the new class, we can replace
> guava.Preconditions.checkNotNull by {{unguava.Validate.checkNotNull}}}}
> * We need the change to go into trunk, 3.1, 3.2, and 3.3
>
> Similar Jiras will be created to implement checkState, checkArgument,
> checkIndex
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
