[
https://issues.apache.org/jira/browse/HADOOP-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140875#comment-13140875
]
Konstantin Shvachko commented on HADOOP-7786:
---------------------------------------------
Eli, the patch looks great.
One thing:
Instead of aConf.get(FS_DEFAULT_NAME_KEY)
It should be aConf.get(FS_DEFAULT_NAME_KEY, FS_DEFAULT_NAME_DEFAULT)
+1 other than that.
Findbugs come from protobuf packages untouched here. Don't understand why
jenkins reported them as new.
> Remove HDFS-specific configuration keys defined in FsConfig
> -----------------------------------------------------------
>
> Key: HADOOP-7786
> URL: https://issues.apache.org/jira/browse/HADOOP-7786
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.21.1
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: HDFS-1900.txt, hadoop-7786-1.patch
>
>
> HADOOP-4952 added a couple HDFS-specific configuration values to common (the
> block size and the replication factor) that conflict with the HDFS values (eg
> have the wrong defaults, wrong key name), are not used by common or hdfs and
> should be removed. After removing these I noticed the rest of FsConfig is
> only used once outside a test, and isn't tagged as a public API, I think we
> can remove it entirely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
