jojochuang commented on a change in pull request #2863:
URL: https://github.com/apache/hadoop/pull/2863#discussion_r639498241
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
##########
@@ -2388,8 +2389,15 @@ private SnapshotDiffReport getSnapshotDiffReportInternal(
List<DiffReportListingEntry> deletedList = new ChunkedArrayList<>();
SnapshotDiffReportListing report;
do {
- report = dfs.getSnapshotDiffReportListing(snapshotDir, fromSnapshot,
- toSnapshot, startPath, index);
+ try {
+ report = dfs.getSnapshotDiffReportListing(snapshotDir, fromSnapshot,
+ toSnapshot, startPath, index);
+ } catch (RpcNoSuchMethodException e) {
+ // In case the server doesn't support getSnapshotDiffReportListing,
+ // fallback to getSnapshotDiffReport.
+ LOG.warn("Falling back to getSnapshotDiffReport {}", e.getMessage());
Review comment:
Should use DFSClient.LOG instead because the rest of code logs using
DFSClient.LOG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
