GauthamBanasandra commented on a change in pull request #3043:
URL: https://github.com/apache/hadoop/pull/3043#discussion_r642809673
##########
File path: dev-support/docker/Dockerfile_centos_7
##########
@@ -23,79 +23,28 @@ WORKDIR /root
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+######
+# Platform package dependency resolver
+######
+COPY pkg-resolver pkg-resolver
+RUN chmod a+x pkg-resolver/*.sh pkg-resolver/*.py \
+ && chmod a+r pkg-resolver/*.json
+
+######
+# Install packages from yum
+######
+# hadolint ignore=DL3008,SC2046
RUN yum update -y \
- && yum install -y centos-release-scl \
- && yum install -y devtoolset-9 \
&& yum install -y \
- ant \
- build-essential \
- bzip2 \
- bzip2-devel \
- clang \
- curl \
- cyrus-sasl-devel \
- doxygen \
- fuse \
- fuse-libs \
- fuse-devel \
- git \
- libcurl-devel \
- libtirpc-devel \
- libpmem-devel \
- libtool \
- lz4-devel \
- make \
- openssl-devel \
- pinentry-curses \
- python3 \
- python3-pip \
- python3-setuptools \
- python3-wheel \
- rsync \
- snappy-devel \
- sudo \
- valgrind \
- zlib-devel
+ centos-release-scl \
+ python3 \
+ && yum install -y $(pkg-resolver/resolve.py centos:7)
# Set GCC 9 as the default C/C++ compiler
RUN echo "source /opt/rh/devtoolset-9/enable" >> /etc/bashrc
SHELL ["/bin/bash", "--login", "-c"]
-####
-# Install Maven 3.6.3
-####
-RUN mkdir -p /opt/maven /tmp/maven \
- && curl -L -s -S
https://mirrors.estointernet.in/apache/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz
\
- -o /tmp/maven/apache-maven-3.6.3-bin.tar.gz \
- && tar xzf /tmp/maven/apache-maven-3.6.3-bin.tar.gz --strip-components 1
-C /opt/maven
-
-####
-# Install CMake 3.19
-####
-# hadolint ignore=DL3003
-RUN mkdir -p /tmp/cmake /opt/cmake \
- && curl -L -s -S https://cmake.org/files/v3.19/cmake-3.19.0.tar.gz -o
/tmp/cmake/cmake-3.19.0.tar.gz \
- && tar xzf /tmp/cmake/cmake-3.19.0.tar.gz --strip-components 1 -C
/opt/cmake \
- && cd /opt/cmake || exit && ./bootstrap \
- && make "-j$(nproc)" \
- && make install \
- && cd /root || exit
-
-####
-# Install zstandard
-####
-# hadolint ignore=DL3003
-RUN mkdir -p /opt/zstd /tmp/zstd \
- && curl -L -s -S
https://github.com/facebook/zstd/archive/refs/tags/v1.4.9.tar.gz -o
/tmp/zstd/v1.4.9.tar.gz \
- && tar xzf /tmp/zstd/v1.4.9.tar.gz --strip-components 1 -C /opt/zstd \
- && cd /opt/zstd || exit \
- && make "-j$(nproc)" \
- && make install \
- && cd /root || exit
-
-RUN locale-gen en_US.UTF-8
-ENV LANG='en_US.UTF-8' LANGUAGE='en_US:en' LC_ALL='en_US.UTF-8'
-ENV PYTHONIOENCODING=utf-8
+# TODO: Set locale
Review comment:
@jojochuang you had set locale in this PR -
https://github.com/apache/hadoop/commit/ad923ad5642b2b11357fbee4277f3435300a19c5.
However, this isn't the way to set the locale in Centos 7 and it currently
fails with a `locale-gen : command not found error`. I've thus, removed it and
added a TODO for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
