tomscut commented on a change in pull request #3062:
URL: https://github.com/apache/hadoop/pull/3062#discussion_r644513026
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NetworkTopologyServlet.java
##########
@@ -90,7 +90,7 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
* @param leaves leaves nodes under base scope
* @param format the response format
*/
- public void printTopology(PrintStream stream, List<Node> leaves,
+ private void printTopology(PrintStream stream, List<Node> leaves,
Review comment:
> Why not just override?
Because the arguments of the two methods are a little different, I'll fix
it. Thank you for pointing that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
