zhaomin1423 commented on pull request #3071: URL: https://github.com/apache/hadoop/pull/3071#issuecomment-854630794
> I've commented on the distcp side of the changes,. > > Regarding FTP > > 1. That Test suite MUST be restored. That's where the entire semantics of rename in the FS are validated. > 2. Looking at the history of the code you are cutting, it went in because FTP couldn't rename files into different directories ([HADOOP-9361](https://issues.apache.org/jira/browse/HADOOP-9361)). > > What has changed since then? > > AFAIK,. the FTP API used by the client has to change to the directory and rename by short name only, not the full the path. Thanks, I will update the distCp side of the changes. Regarding FTP, the test suite could be need to modify. After my test using commons-net:3.6, the rename can be work using the full path, just only have the parent directory, and don't have the limit of source path and target path have common parent directory. So, I think the rename method of FTPFilesystem should be modified so that it has the same behavior as other file systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
