[
https://issues.apache.org/jira/browse/HADOOP-17463?focusedWorklogId=607341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607341
]
ASF GitHub Bot logged work on HADOOP-17463:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/21 21:52
Start Date: 04/Jun/21 21:52
Worklog Time Spent: 10m
Work Description: amahussein commented on pull request #2615:
URL: https://github.com/apache/hadoop/pull/2615#issuecomment-855020066
I haven't seen the discussion when I searched for old jiras.
Thanks @jbrennan333 and @ayushtkn for the feedback.
Closing the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607341)
Time Spent: 1h 40m (was: 1.5h)
> Replace currentTimeMillis with monotonicNow in elapsed time
> -----------------------------------------------------------
>
> Key: HADOOP-17463
> URL: https://issues.apache.org/jira/browse/HADOOP-17463
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> I noticed that there is a widespread incorrect usage of
> {{System.currentTimeMillis()}} throughout the hadoop code.
> For example:
> {code:java}
> // Some comments here
> long start = System.currentTimeMillis();
> while (System.currentTimeMillis() - start < timeout) {
> // Do something
> }
> {code}
> Elapsed time should be measured using `monotonicNow()`.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
