[
https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359058#comment-17359058
]
Wei-Chiu Chuang commented on HADOOP-15327:
------------------------------------------
Thanks...
1. Change category #5, closing channels with:
future.channel().closeFuture().awaitUninterruptibly()
Could you please tell me how did you find out to close a channel like this? As
mentioned above, I couldn't find any resource to justify this.
Channel.close() in netty4 takes a Future parameter.
But In fact, this is a bad practice according to the official doc:
https://netty.io/4.0/api/io/netty/channel/ChannelFuture.html
"Do not call await() inside ChannelHandler"
> Upgrade MR ShuffleHandler to use Netty4
> ---------------------------------------
>
> Key: HADOOP-15327
> URL: https://issues.apache.org/jira/browse/HADOOP-15327
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Szilard Nemeth
> Priority: Major
>
> This way, we can remove the dependencies on the netty3 (jboss.netty)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
