surendralilhore commented on a change in pull request #2520:
URL: https://github.com/apache/hadoop/pull/2520#discussion_r650787085



##########
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -142,6 +156,10 @@ public String getPath() {
     return path;
   }
 
+  private String getInputStreamID() {
+    return StringUtils.right(UUID.randomUUID().toString(), STREAM_ID_LEN);

Review comment:
       Why this applicable for only stream id, not for filesystem id ? ?

##########
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java
##########
@@ -109,6 +109,12 @@
    *  Default value of this config is true. **/
   public static final String FS_AZURE_DISABLE_OUTPUTSTREAM_FLUSH = 
"fs.azure.disable.outputstream.flush";
   public static final String FS_AZURE_USER_AGENT_PREFIX_KEY = 
"fs.azure.user.agent.prefix";
+  /**
+   * The client correlation ID provided over config that will be added to
+   * x-ms-client-request-Id header. Defaults to empty string if the length and
+   * character constraints are not satisfied. **/
+  public static final String FS_AZURE_CLIENT_CORRELATIONID = 
"fs.azure.client.correlationid";

Review comment:
       Can you give me the example of possible value ?
   What if in same jvm two FS objects are there ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to