majdyz commented on pull request #3109: URL: https://github.com/apache/hadoop/pull/3109#issuecomment-864940353
Hi @bogthe thanks for the feedback. Sorry for getting back on this late, I'm running the test right now and will get back on this soon. And for the testing part: - Aside from the `.getObjectContent()` we also need to get the current implementation of the retry policy (the part where we have delay before the next retry) which attached in the `S3AReadOpContext`. I tried to keep the mocking minimum by only setting the behaviour of the inputStream, but to attach this we need to go from `InputStreamCallbacks` -> `S3Object` -> `S3ObjectInputStream` so two small mockings before that are needed. Let me know if there could be a better approach for this. - For the failure scenario, I provided these two tests where the current implementation breaks, let me know if there is any other scenario I should provide for the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
