akshatb1 commented on a change in pull request #3135:
URL: https://github.com/apache/hadoop/pull/3135#discussion_r658783221
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java
##########
@@ -54,4 +64,69 @@ public GetClusterMetricsResponse
getClusterMetricsResponse(int value) {
metrics.setNumNodeManagers(value);
return GetClusterMetricsResponse.newInstance(metrics);
}
+
+ /**
+ * This test validates the correctness of
+ * RouterYarnClientUtils#mergeApplications.
+ */
+ @Test
+ public void testMergeApplications() {
+ ArrayList<GetApplicationsResponse> responses = new ArrayList<>();
+ responses.add(getApplicationsResponse(1));
+ responses.add(getApplicationsResponse(2));
+ GetApplicationsResponse result = RouterYarnClientUtils.
+ mergeApplications(responses, false);
+ Assert.assertNotNull(result);
+ Assert.assertEquals(2, result.getApplicationList().size());
+ }
+
+ /**
+ * This generates a GetApplicationsResponse with 2 applications with
+ * same ApplicationId. One of them is added with host value equal to
+ * null to validate unmanaged application merge with managed application.
+ * @param value Used as Id in ApplicationId
+ * @return GetApplicationsResponse
+ */
+ private GetApplicationsResponse getApplicationsResponse(int value) {
+ List<ApplicationReport> applications = new ArrayList<>();
+
+ //Add managed application to list
+ ApplicationId appId = ApplicationId.newInstance(1234,
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
