[
https://issues.apache.org/jira/browse/HADOOP-17139?focusedWorklogId=615031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615031
]
ASF GitHub Bot logged work on HADOOP-17139:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/21 14:29
Start Date: 25/Jun/21 14:29
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #3101:
URL: https://github.com/apache/hadoop/pull/3101#issuecomment-868540988
> listFilesAndDirs a new RemoteIterator similar to listFiles that includes
LocatedFileStatus for directories too. It's handy when we want to detect empty
directories;
-1 to that change.
Making FS changes is a big thing with more trauma and planning. See the
comments at the top of FileSystem.java.
Any new list operation should
* support multiple dirs (for faster partition scanning)
* builder API for any specific options
* return a list of Future<>s to make clear that list can be slow & return
dirs out of order
* has high performance impl for HDFS/webHDFS as well as "S3A And ABFS object
stores (could just relay to BatchListingOperations & so existing results.)
* Plus all the spec/contract work.
See HADOOP-16898 for discussion there.
It's not trivial -we need to think about "what is the best list model for
the future?".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 615031)
Time Spent: 0.5h (was: 20m)
> Re-enable optimized copyFromLocal implementation in S3AFileSystem
> -----------------------------------------------------------------
>
> Key: HADOOP-17139
> URL: https://issues.apache.org/jira/browse/HADOOP-17139
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0, 3.2.1
> Reporter: Sahil Takiar
> Assignee: Bogdan Stolojan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It looks like HADOOP-15932 disabled the optimized copyFromLocal
> implementation in S3A for correctness reasons. innerCopyFromLocalFile should
> be fixed and re-enabled. The current implementation uses
> FileSystem.copyFromLocal which will open an input stream from the local fs
> and an output stream to the destination fs, and then call IOUtils.copyBytes.
> With default configs, this will cause S3A to read the file into memory, write
> it back to a file on the local fs, and then when the file is closed, upload
> it to S3.
> The optimized version of copyFromLocal in innerCopyFromLocalFile, directly
> creates a PutObjectRequest request with the local file as the input.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
