bogthe commented on pull request #3101:
URL: https://github.com/apache/hadoop/pull/3101#issuecomment-871465091
New changes:
- Reverted previous change to FS interface;
- New abstract test class `AbstractContractCopyFromLocalTest` with the old
tests from `ITestS3ACopyFromLocalFile` and more to handle edge cases,
implemented for S3a in `ITestS3ACopyFromLocalFile` and LocalFS in
`TestLocalFSCopyFromLocal`;
- `copyFromLocal` from S3a now handles copies in the same way as the
`LocalFS` implementation with 1 minor difference when handling source directory
and destination file:
- S3a: throws `PathExistsException`;
- LocalFS: throws `FileAlreadyExistsException`;
- Not clear if there are dependencies of S3a expecting
`PathExistsException` or we can move to using `FileAlreadyExistsException` for
both. @steveloughran
What's left:
- updates to `filesystem.md`;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
