steveloughran commented on pull request #3076:
URL: https://github.com/apache/hadoop/pull/3076#issuecomment-872978647
changes look good. This leaves checkstyle complaints to deal with.
Indentation and some lines need to be split.
+1 pending these changes
```
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:32:
@Test: 'method def modifier' has incorrect indentation level 4, expected
level should be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:34:
InterruptedIOException inputException = new
InterruptedIOException("message");: 'method def' child has incorrect
indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:34:
InterruptedIOException inputException = new
InterruptedIOException("message");: Line is longer than 80 characters (found
86). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:35:
NullPointerException causeException = new
NullPointerException("cause");: 'method def' child has incorrect indentation
level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:36:
inputException.initCause(causeException);: 'method def' child has
incorrect indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:37:
Exception outputException = IOUtils.wrapException("path", "methodName",
inputException);: 'method def' child has incorrect indentation level 8,
expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:37:
Exception outputException = IOUtils.wrapException("path", "methodName",
inputException);: Line is longer than 80 characters (found 96). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:40:
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);:
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:40:
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);:
Line is longer than 80 characters (found 90). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:41:
Assertions.assertThat(outputException.getCause()).isInstanceOf(NullPointerException.class):
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:41:
Assertions.assertThat(outputException.getCause()).isInstanceOf(NullPointerException.class):
Line is longer than 80 characters (found 98). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:43:
assertEquals(outputException.getMessage(),
inputException.getMessage());: 'method def' child has incorrect indentation
level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:44:
assertEquals(outputException.getCause(), inputException.getCause());:
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:45:
}: 'method def rcurly' has incorrect indentation level 4, expected level
should be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:47:
@Test: 'method def modifier' has incorrect indentation level 4, expected
level should be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:48:
public void testWrapExceptionWithInterruptedCauseException() throws
Exception {: Line is longer than 80 characters (found 83). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:49:
IOException inputException = new IOException("message");: 'method def'
child has incorrect indentation level 8, expected level should be 4.
[Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:50:
InterruptedException causeException = new
InterruptedException("cause");: 'method def' child has incorrect indentation
level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:51:
inputException.initCause(causeException);: 'method def' child has
incorrect indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:52:
Exception outputException = IOUtils.wrapException("path", "methodName",
inputException);: 'method def' child has incorrect indentation level 8,
expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:52:
Exception outputException = IOUtils.wrapException("path", "methodName",
inputException);: Line is longer than 80 characters (found 96). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:55:
// but be an InterruptedIOException because the cause was an
InterruptedException: Line is longer than 80 characters (found 89). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:56:
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);:
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:56:
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);:
Line is longer than 80 characters (found 90). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:57:
Assertions.assertThat(outputException.getCause()).isInstanceOf(InterruptedException.class);:
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:57:
Assertions.assertThat(outputException.getCause()).isInstanceOf(InterruptedException.class);:
Line is longer than 80 characters (found 99). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:58:
assertEquals("getMessage()",: 'method def' child has incorrect
indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:60:
assertEquals("getCause()",: 'method def' child has incorrect
indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:62:
}: 'method def rcurly' has incorrect indentation level 4, expected level
should be 2. [Indentation]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
