[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618769
]
ASF GitHub Bot logged work on HADOOP-17765:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/21 19:53
Start Date: 05/Jul/21 19:53
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3122:
URL: https://github.com/apache/hadoop/pull/3122#discussion_r664106486
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemBackCompat.java
##########
@@ -50,13 +52,17 @@ public void testBlobBackCompat() throws Exception {
CloudBlobContainer container =
blobClient.getContainerReference(this.getFileSystemName());
container.createIfNotExists();
- CloudBlockBlob blockBlob =
container.getBlockBlobReference("test/10/10/10");
+ String testPath = "test" + UUID.randomUUID();
+ CloudBlockBlob blockBlob = container
+ .getBlockBlobReference(testPath + "/10/10/10");
blockBlob.uploadText("");
- blockBlob = container.getBlockBlobReference("test/10/123/3/2/1/3");
+ blockBlob = container.getBlockBlobReference(testPath + "/10/123/3/2/1/3");
blockBlob.uploadText("");
- FileStatus[] fileStatuses = fs.listStatus(new Path("/test/10/"));
+ System.out.println(new Path(String.format("%s/10/", testPath)));
Review comment:
use SLF4J logger
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestCustomerProvidedKey.java
##########
@@ -106,7 +106,7 @@ public ITestCustomerProvidedKey() throws Exception {
@Test
public void testReadWithCPK() throws Exception {
final AzureBlobFileSystem fs = getAbfs(true);
- String fileName = path("/" + methodName.getMethodName()).toString();
+ String fileName = "/" + methodName.getMethodName();
Review comment:
so this moves away from path(). why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 618769)
Time Spent: 2h 20m (was: 2h 10m)
> ABFS: Use Unique File Paths in Tests
> ------------------------------------
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.1
> Reporter: Sumangala Patki
> Assignee: Sumangala Patki
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Many of ABFS driver tests use common names for file paths (e.g.,
> "/testfile"). This poses a risk of errors during parallel test runs when
> static variables (such as those for monitoring stats) affected by file paths
> are introduced.
> Using unique test file names will avoid possible errors arising from shared
> resources during parallel runs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
