[
https://issues.apache.org/jira/browse/HADOOP-17795?focusedWorklogId=621580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621580
]
ASF GitHub Bot logged work on HADOOP-17795:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/21 19:54
Start Date: 12/Jul/21 19:54
Worklog Time Spent: 10m
Work Description: tasanuma commented on a change in pull request #3192:
URL: https://github.com/apache/hadoop/pull/3192#discussion_r667842295
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -714,13 +714,40 @@ private String getQueueClassPrefix() {
return CommonConfigurationKeys.IPC_NAMESPACE + "." + port;
}
+ @Deprecated
Review comment:
Is there a problem with simply deleting it?
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -714,13 +714,40 @@ private String getQueueClassPrefix() {
return CommonConfigurationKeys.IPC_NAMESPACE + "." + port;
}
+ @Deprecated
Review comment:
Is there a problem with simply deleting the method?
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -714,13 +714,40 @@ private String getQueueClassPrefix() {
return CommonConfigurationKeys.IPC_NAMESPACE + "." + port;
}
+ @Deprecated
Review comment:
@jojochuang Thanks for your explanation. I understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621580)
Time Spent: 50m (was: 40m)
> Provide fallbacks for callqueue.impl and scheduler.impl
> -------------------------------------------------------
>
> Key: HADOOP-17795
> URL: https://issues.apache.org/jira/browse/HADOOP-17795
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> As mentioned in parent Jira, we should provide default properties for
> callqueue.impl and scheduler.impl such that if properties with port is not
> configured, we can fallback to default property. If "ipc.8020.callqueue.impl"
> is not present, fallback property could be "ipc.callqueue.impl" (without
> port). We can take up rest of the callqueue properties in separate sub-tasks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
