abhishekdas99 commented on pull request #2260: URL: https://github.com/apache/hadoop/pull/2260#issuecomment-878573343
> Looks good generally. I checked the tests are catching previous errors. > > * There seems to be one last checkstyle warning. > * Also I see you use `import static org.junit.Assert.*;` and `viewfs.Constants.*;` We should import only what is actually needed. Avoid *-imports. > * And I found an empty line added in `ViewFileSystem`. Don't know why checkstyle didn't catch it. @shvachko I have removed the checkstyle warning. Also added the individual imports and removed the empty line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
