virajjasani commented on a change in pull request #3198:
URL: https://github.com/apache/hadoop/pull/3198#discussion_r670284023
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
##########
@@ -97,10 +98,25 @@
public String name() { return name; }
public static RpcMetrics create(Server server, Configuration conf) {
+ setMetricTimeUnit(conf);
RpcMetrics m = new RpcMetrics(server, conf);
return DefaultMetricsSystem.instance().register(m.name, null, m);
}
+ private static void setMetricTimeUnit(Configuration conf) {
Review comment:
Agree, let me make it this way. If server is instance of `RPC.Server`,
we can make this change so that for anyone extending this Server from
downstream application does not interfere with core-site config used in core
Hadoop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
