steveloughran commented on a change in pull request #3202:
URL: https://github.com/apache/hadoop/pull/3202#discussion_r670355071
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/UnknownStoreException.java
##########
@@ -33,23 +32,28 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class UnknownStoreException extends IOException {
+public class UnknownStoreException extends PathIOException {
/**
* Constructor.
- * @param message message
+ *
+ * @param message message.
+ * @param path path trying to access.
*/
- public UnknownStoreException(final String message) {
- this(message, null);
+ public UnknownStoreException(final String message, final String path) {
+ this(message, null, path);
}
/**
* Constructor.
- * @param message message
- * @param cause cause (may be null)
+ *
+ * @param message message.
+ * @param cause cause (may be null).
+ * @param path path trying to access.
*/
- public UnknownStoreException(final String message, Throwable cause) {
- super(message);
+ public UnknownStoreException(final String message, Throwable cause,
Review comment:
same
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/UnknownStoreException.java
##########
@@ -33,23 +32,28 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class UnknownStoreException extends IOException {
+public class UnknownStoreException extends PathIOException {
/**
* Constructor.
- * @param message message
+ *
+ * @param message message.
+ * @param path path trying to access.
*/
- public UnknownStoreException(final String message) {
- this(message, null);
+ public UnknownStoreException(final String message, final String path) {
Review comment:
can you move path to be the first argument, to be consistent with
PathIOE itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
