[
https://issues.apache.org/jira/browse/HADOOP-16290?focusedWorklogId=623496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623496
]
ASF GitHub Bot logged work on HADOOP-16290:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/21 09:25
Start Date: 16/Jul/21 09:25
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3198:
URL: https://github.com/apache/hadoop/pull/3198#discussion_r671091992
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
##########
@@ -49,7 +51,7 @@
final String name;
final boolean rpcQuantileEnable;
/** The time unit used when storing/accessing time durations. */
- public final static TimeUnit TIMEUNIT = TimeUnit.MILLISECONDS;
+ private static TimeUnit metricsTimeUnit = TimeUnit.MILLISECONDS;
Review comment:
Since this is static, setting in constructor might not be that accurate
(also it produces spotbugs, as per first QA result
e.g `Write to static field
org.apache.hadoop.ipc.metrics.RpcMetrics.metricsTimeUnit from instance method
new org.apache.hadoop.ipc.metrics.RpcMetrics(Server, Configuration) At
RpcMetrics.java:from instance method new
org.apache.hadoop.ipc.metrics.RpcMetrics(Server, Configuration) At
RpcMetrics.java:[line 70]`
).
And `static final` will always require us to provide value in static context
outside constructor, that's why we are not able to use it as `final`
unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 623496)
Time Spent: 3h (was: 2h 50m)
> Enable RpcMetrics units to be configurable
> ------------------------------------------
>
> Key: HADOOP-16290
> URL: https://issues.apache.org/jira/browse/HADOOP-16290
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc, metrics
> Reporter: Erik Krogen
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> One resulting discussion from HADOOP-16266 was that it would be better for
> the RPC metrics (processing time, queue time) to be in micro- or nanoseconds,
> since milliseconds does not accurately capture the processing time of many
> RPC operations. HADOOP-16266 made some small changes in this direction, but
> to keep the size of the patch down, we did not make it fully configurable. We
> can complete that work here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
