virajjasani commented on a change in pull request #3198:
URL: https://github.com/apache/hadoop/pull/3198#discussion_r671664524
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
##########
@@ -49,7 +51,7 @@
final String name;
final boolean rpcQuantileEnable;
/** The time unit used when storing/accessing time durations. */
- public final static TimeUnit TIMEUNIT = TimeUnit.MILLISECONDS;
+ private static TimeUnit metricsTimeUnit = TimeUnit.MILLISECONDS;
Review comment:
I just realized that default implementation of `RpcScheduler` that
requires metric unit is just to maintain backward compatibility with old
implementations hence we can let it use default timeunit. Since all new impl
are supposed to implement `addResponseTime()`, I think we can make this
non-static in RpcMetrics.
Let me make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
